argoproj-labs / argocd-vault-plugin

An Argo CD plugin to retrieve secrets from Secret Management tools and inject them into Kubernetes secrets
https://argocd-vault-plugin.readthedocs.io
Apache License 2.0
812 stars 190 forks source link

fix(deps): upgrade aws-sdk-go-v2 #644

Closed Timothy-Dement closed 3 months ago

Timothy-Dement commented 3 months ago

Description

AWS Secrets Manager functionality is broken in version v1.18.0 due to https://github.com/aws/aws-sdk-go-v2/issues/2370.

As referenced in that issue and in the comment by @sneaker-xc3 here, the fix is to upgrade the aws-sdk-go-v2 dependencies:

go get -u github.com/aws/aws-sdk-go-v2/...

That has been done in this pull request, along with the required tidy command:

go mod tidy -compat=1.21

Fixes: https://github.com/argoproj-labs/argocd-vault-plugin/issues/643

Checklist

Type of Change

Other information

As @sneaker-xc3 noted here, it would be good for this to prompt a new version release - Homebrew pulls down v1.18.0 which does not work with AWS Secrets Manager currently.

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.55%. Comparing base (42a43f0) to head (a1bd8ce). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #644 +/- ## ========================================== + Coverage 72.16% 73.55% +1.38% ========================================== Files 26 26 Lines 1994 1588 -406 ========================================== - Hits 1439 1168 -271 + Misses 458 315 -143 - Partials 97 105 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.