Fix #680: Fail if placeholder resolves to binary data, that would break yaml - Githubissues

argoproj-labs / argocd-vault-plugin

An Argo CD plugin to retrieve secrets from Secret Management tools and inject them into Kubernetes secrets

https://argocd-vault-plugin.readthedocs.io

Apache License 2.0

834 stars 193 forks source link

Fix #680: Fail if placeholder resolves to binary data, that would break yaml #681

Open olivergondza opened 1 day ago

olivergondza commented 1 day ago

Description

Fail fast if placeholder is to produce binary data. This provides better error message to diagnose misconfiguration.

Fixes: https://github.com/argoproj-labs/argocd-vault-plugin/issues/680

Checklist

Please make sure that your PR fulfills the following requirements:

[x] Reviewed the guidelines for contributing to this repository
[x] The commit message follows the Conventional Commits Guidelines.
[x] Tests for the changes have been updated
[N/A] Are you adding dependencies? If so, please run go mod tidy -compat=1.22.7 to ensure only the minimum is pulled in.
[N/A] Docs have been added / updated
[ ] Optional. My organization is added to USERS.md.

Type of Change

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

Other information