search

argoproj-labs / hera

Hera makes Python code easy to orchestrate on Argo Workflows through native Python integrations. It lets you construct and submit your Workflows entirely in Python. ⭐️ Remember to star!
https://hera.rtfd.io
Apache License 2.0
601 stars 106 forks source link

fix macos runners #1040

Closed crflynn closed 6 months ago

crflynn commented 6 months ago

Pull Request Checklist

Description of PR https://github.com/actions/runner-images/issues/9770 With macos-latest moving from macos-12 to macos-14, there are fewer available python versions.

This PR pins the previous macos-latest runner to macos-12 and adds entries for python 3.11 and 3.12 available on macos-14.

Also, it looks like the required status checks need to be updated.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.8%. Comparing base (d553546) to head (cd92543). Report is 133 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1040 +/- ## ======================================= + Coverage 81.7% 81.8% +0.1% ======================================= Files 54 56 +2 Lines 4208 4228 +20 Branches 889 892 +3 ======================================= + Hits 3439 3461 +22 + Misses 574 571 -3 - Partials 195 196 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sambhav commented 6 months ago

@crflynn Thanks for the fix. I'm going to limit it to Python 3.11 for now. Will add 3.12 in another PR along with Linux.

flaviuvadan commented 6 months ago

Thank you @crflynn!