search

argoproj-labs / hera

Hera is an Argo Python SDK. Hera aims to make construction and submission of various Argo Project resources easy and accessible to everyone! Hera abstracts away low-level setup details while still maintaining a consistent vocabulary with Argo. ⭐️ Remember to star!
https://hera.rtfd.io
Apache License 2.0
550 stars 105 forks source link

Add client certificates for workflow service and global. Fixes #1079 #1087

Closed mrendi29 closed 2 months ago

mrendi29 commented 2 months ago

Pull Request Checklist

Description of PR This PR adds support to add user supported certificates and keys.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.8%. Comparing base (d553546) to head (6d80136). Report is 79 commits behind head on main.

Files Patch % Lines
src/hera/shared/_global_config.py 66.6% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1087 +/- ## ======================================= + Coverage 81.7% 81.8% +0.1% ======================================= Files 54 60 +6 Lines 4208 4632 +424 Branches 889 973 +84 ======================================= + Hits 3439 3793 +354 - Misses 574 612 +38 - Partials 195 227 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mrendi29 commented 2 months ago

@flaviuvadan I am also thinking to add some documentation into hera/docs/walk-through/authentication.md what do you think?

flaviuvadan commented 2 months ago

@flaviuvadan I am also thinking to add some documentation into hera/docs/walk-through/authentication.md what do you think?

This sounds great!

samj1912 commented 2 months ago

@samj1912 thoughts on this? This looks like a great addition to me

Will take a look tomorrow morning LDN time :)