search

argoproj-labs / hera

Hera is an Argo Python SDK. Hera aims to make construction and submission of various Argo Project resources easy and accessible to everyone! Hera abstracts away low-level setup details while still maintaining a consistent vocabulary with Argo. ⭐️ Remember to star!
https://hera.rtfd.io
Apache License 2.0
550 stars 105 forks source link

Explicitly re-export models #1116

Closed DanCardin closed 1 month ago

DanCardin commented 1 month ago

Is your feature request related to a problem? Please describe. Commonly installed python linter pyright complains about implicit reexport

Screenshot 2024-07-01 at 5 06 39 PM

While hera/workflows/models/init.py imports all the deeper models, it does not add them to an __all__ block.

Describe the solution you'd like Ideally all the models are explicitly reexported, so linters dont complain about it

Describe alternatives you've considered Perhaps there's a way of configuring pyright to not care about this, but it seems beneficial to fix the default behavior here. particularly in this case where the file seems to be autogenerated and defining the explicit reexport block ought to be relatively straightforward?

I'd be down to contribute the fix if interested. It's this file?

flaviuvadan commented 1 month ago

I'd be down to contribute the fix if interested. It's this file?

That's definitely the right place for it! Thanks for bringing this up!