search

argoproj-labs / hera

Hera makes Python code easy to orchestrate on Argo Workflows through native Python integrations. It lets you construct and submit your Workflows entirely in Python. ⭐️ Remember to star!
https://hera.rtfd.io
Apache License 2.0
601 stars 106 forks source link

Update script to handle Optional and Union input parameters #1160

Closed jeongukjae closed 2 months ago

jeongukjae commented 2 months ago

Pull Request Checklist

Description of PR Currently, script decorator cannot handle Union or Optional input parameters because of the error in issubclass, so updated it to be able to handle it as expected.

original PR: https://github.com/argoproj-labs/hera/pull/1147

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.4%. Comparing base (d553546) to head (f24a7c9). Report is 126 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1160 +/- ## ======================================= - Coverage 81.7% 81.4% -0.3% ======================================= Files 54 60 +6 Lines 4208 4732 +524 Branches 889 1004 +115 ======================================= + Hits 3439 3856 +417 - Misses 574 646 +72 - Partials 195 230 +35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.