Closed vikramsg closed 11 months ago
Seems like the reverse of https://github.com/argoproj-labs/hera/issues/636 at first glance.
This issue is because we added https://github.com/argoproj-labs/hera/blob/206b51a8fffcad3fda7e2f042a27c1451f10cf25/src/hera/shared/_base_model.py#L30-L31
It may be related, I have the same issue but it's just when requesting the list of CRON workflows:
service = WorkflowsService(host=configuration.ARGO_SERVICE_URI, token=configuration.ARGO_SERVICE_API_KEY)
cron_workflows = service.list_cron_workflows(namespace=configuration.ENVIRONMENT_NAME)
StackTrace:
cron_workflows = service.list_cron_workflows(namespace=configuration.ENVIRONMENT_NAME)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "d:\usr\venv\Lib\site-packages\hera\workflows\service.py", line 417, in list_cron_workflows
return CronWorkflowList(**resp.json())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "pydantic\main.py", line 341, in pydantic.main.BaseModel.__init__
pydantic.error_wrappers.ValidationError: 63 validation errors for CronWorkflowList
items -> 0 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 0 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 0 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 0 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 1 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 1 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 1 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 2 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 2 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 2 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 3 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 3 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 3 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 4 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 4 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 4 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 5 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 5 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 5 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 6 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 6 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 6 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 7 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 7 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 7 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 8 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 8 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 8 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 9 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 9 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 9 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 10 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 10 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 10 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 11 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 11 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 11 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 12 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 12 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 12 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 13 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 13 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 13 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 13 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 14 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 14 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 14 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 14 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 15 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 15 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 15 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 15 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 16 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 16 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 16 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 17 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 17 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 17 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 17 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
items -> 18 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 18 -> metadata -> managedFields -> 0 -> fieldsV1 -> f:spec
extra fields not permitted (type=value_error.extra)
items -> 18 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:metadata
extra fields not permitted (type=value_error.extra)
items -> 18 -> metadata -> managedFields -> 1 -> fieldsV1 -> f:status
extra fields not permitted (type=value_error.extra)
With 5.9 worked fine.
CC @flaviuvadan maybe we should prioritise #652 to solve this in future? π
I think I would prefer to revert this change temporarily and cut a patch release ASAP.
Fixed with 5.10.1
Pre-bug-report checklist
1. This bug can be reproduced using pure Argo YAML
If yes, it is more likely to be an Argo bug unrelated to Hera. Please double check before submitting an issue to Hera.
2. This bug occurs in Hera when...
Bug report
Describe the bug I have a workflow that worked fine with Hera 5.9 but stopped working with 5.10. The errors shown are not very helpful in terms of trying to debug.
To Reproduce Full Hera code to reproduce the bug:
Expected behavior Workflow should just work as it did for 5.9.
Environment