argoproj-labs / rollout-extension

Argo Rollout visualization in Argo CD Web UI
195 stars 46 forks source link

No container or image tag shown on the dashboard #56

Open beyondbill opened 1 year ago

beyondbill commented 1 year ago

What ArgoCD dashboard shows

Screenshot 2023-09-11 at 2 29 25 PM

The same Rollout in Argo Rollouts Dashboard

image

The Rollout's template

apiVersion: argoproj.io/v1alpha1
kind: Rollout
metadata:
  annotations:
    rollout.argoproj.io/revision: "586"
    rollout.argoproj.io/workload-generation: "724"
  creationTimestamp: "2023-06-28T16:30:09Z"
  labels:
    argocd.argoproj.io/instance: orchestrator-69ff9
  name: orchestrator
  namespace: orchestrator
spec:
  replicas: 2
  strategy:
    canary:
      analysis:
        args:
        - name: appName
          valueFrom:
            fieldRef:
              fieldPath: metadata.name
        - name: k8sCluster
          value: gcp/frontend-staging-1-us-central1
        - name: k8sNamespace
          valueFrom:
            fieldRef:
              fieldPath: metadata.namespace
        - name: canaryPodHash
          valueFrom:
            podTemplateHashValue: Latest
        templates:
        - clusterScope: true
          templateName: error-rate
        - clusterScope: true
          templateName: latency-average
        - clusterScope: true
          templateName: cpu-utilization
        - clusterScope: true
          templateName: memory-utilization
      canaryService: orchestrator-canary
      stableService: orchestrator
      steps:
      - setWeight: 20
      - pause:
          duration: 10m
      - setWeight: 50
      - pause:
          duration: 5m
      trafficRouting:
        nginx:
          stableIngress: orchestrator-ingress
  workloadRef:
    apiVersion: apps/v1
    kind: Deployment
    name: orchestrator

ArgoCD version is v2.5.5 Argo Rollouts version is v1.4.0 Rollout-extension version is v0.3.1 Kubernetes version is v1.24.14

I don't think this is a permission issue as the SA used by ArgoCD server has been bind to a k8s clusterrole with full permissions

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
  name: argocd-manager-role
rules:
- apiGroups:
  - '*'
  resources:
  - '*'
  verbs:
  - '*'
- nonResourceURLs:
  - '*'
  verbs:
  - '*'
alexmt commented 1 year ago

I'm seeing the same issue. v0.3.0 does not have this issue

beyondbill commented 1 year ago

Thanks @alexmt ! I'll use v0.3.0 until the issue is resolved

beyondbill commented 1 year ago

@alexmt I downgraded to v0.3.0 and now I cannot even see any useful information on the dashboard...

image
winterhalder commented 1 year ago

So - I think there is a fix for this all ready and merged. https://github.com/argoproj-labs/rollout-extension/pull/55

Any chance we'll get a new release soon?

beyondbill commented 12 months ago

@winterhalder Unfortunately the issue persists after I upgraded to v0.3.3, which includes your commit

beyondbill commented 9 months ago
Screenshot 2024-01-22 at 11 40 38 AM

The same issue still persists even after upgrading the extension to v0.3.3

beyondbill commented 9 months ago

Actually, I realize the actual installed version is v0.3.1. It's because the installer has not been updated with the new release of v0.3.3. I have opened a PR to fix it https://github.com/argoproj-labs/rollout-extension/pull/69

beyondbill commented 9 months ago
image

Confirmed that this issue is fixed

beyondbill commented 9 months ago

Sorry for the back and forth. I was careless. But this issue has not been fixed by v0.3.3. The screenshot above is actually showing the exact same issue as originally described

alexmt commented 9 months ago

Thank you for testing it !