argoproj-labs / rollout-extension

Argo Rollout visualization in Argo CD Web UI
196 stars 46 forks source link

Update since argocd-extensions is deprecated #62

Closed otherguy closed 5 months ago

otherguy commented 11 months ago

Now that argocd-extensions is deprecated, will this repo be updated for the new way of defining extensions?

abhishekpolavarapu commented 11 months ago

I dont think, any update is required for this to use with new argocd-extensions-installer If you are using argocd helm you can use this extension by configuring argocd like below:

   server:
    initContainers:
      - name: extension-rollouts
        image: quay.io/argoprojlabs/argocd-extension-installer:v0.0.1
        env:
        - name: HTTPS_PROXY
          value: http://proxy.config.pcp.local:3128
        - name: EXTENSION_URL
          value: https://github.com/argoproj-labs/rollout-extension/releases/download/v0.3.3/extension.tar
        volumeMounts:
          - name: extensions
            mountPath: /tmp/extensions/
        securityContext:
          runAsUser: 1000
          allowPrivilegeEscalation: false
    volumeMounts:
    - name: extensions
      mountPath: /tmp/extensions/
    volumes:
    - name: extensions
      emptyDir: {}
nitishkrishna commented 11 months ago

Which versions of ArgoCD is this expected to work with? I am running ArgoCD v2.7.10 and Rollouts version 2.32.7 and I can't see the "More" tab in the ArgoCD UI but I CAN see the Abort/Promote-full etc options in the drop down menu.

nitishkrishna commented 11 months ago

Strange, figured this out, seems like you ALSO need to add

  extensions:
    enabled: true

to get the extensions sidecar. So now we need both the init container AND the sidecar?

abhishekpolavarapu commented 11 months ago

its either sidecar or init container approach but it appears init container approach is preferred one going forward

avo-sepp commented 10 months ago

Strange, figured this out, seems like you ALSO need to add

  extensions:
    enabled: true

to get the extensions sidecar. So now we need both the init container AND the sidecar?

Where are you adding this?

standardloop commented 9 months ago

Strange, figured this out, seems like you ALSO need to add

  extensions:
    enabled: true

to get the extensions sidecar. So now we need both the init container AND the sidecar?

Where are you adding this?

@avo-sepp

I beilieve they are adding it in a helm values file.

You can see Helm Chart Default Values Here

server.extensions.enabled

ajax-bychenok-y commented 9 months ago

Unfortunately for now quay.io/argoprojlabs/argocd-extension-installer:v0.0.1 is amd64 only, but it's easy to build this image for arm64 https://github.com/argoproj-labs/argocd-extension-installer