argoproj-labs / terraform-provider-argocd

Terraform provider for Argo CD
Mozilla Public License 2.0
424 stars 90 forks source link

need to add other resources in validResources of rbac #345

Open Ajay-Chidambaram opened 1 year ago

Ajay-Chidambaram commented 1 year ago

Description

Need to include other resources like applicationsets, extension, certificates .. in the validResources for the rbac

Potential Terraform Configuration

So far it seems only the below resources are supported through this provider

var validResources = map[string]bool{
    "applications": true,
    "repositories": true,
    "clusters":     true,
    "exec":         true,
    "logs":         true,
}

References

I don't see any issues wrt to this.

Community Note

onematchfox commented 1 year ago

For full set of resources see https://github.com/argoproj/argo-cd/blob/master/server/rbacpolicy/rbacpolicy.go. Where possible we should use code exported by that package.

Ajay-Chidambaram commented 1 year ago

For full set of resources see https://github.com/argoproj/argo-cd/blob/master/server/rbacpolicy/rbacpolicy.go. Where possible we should use code exported by that package.

Oh my bad, so is it something which needs to be fixed from argo-cd project side in the first place ?

onematchfox commented 1 year ago

Oh my bad, so is it something which needs to be fixed from argo-cd project side in the first place ?

Nope. We need to keep the list here in sync with ArgoCD - our code is based on an older, outdated implementation copied from ArgoCD. I was just leaving pointers for anyone who may want to try tackling this.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.