search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.06k stars 5.52k forks source link

Sidecar aware log viewer #10090

Open giovanism opened 2 years ago

giovanism commented 2 years ago

Summary

ArgoCD log viewer already separated init-container with the rest of the containers, let's also add sidecar container. User can directly see the log relevant to them instead of switching from sidecar container every time they open log viewer.

Motivation

My project use sidecar and the new log viewer UI hides the container selection to an obscure button. This gives a hard time to someone new to ArgoCD as they don't immediately see the log relevant to them or aware they are looking at sidecar logs.

Proposal

How do you think this should be implemented?

Will wait to validate the motivation before I come up with something.

sharpyy commented 2 years ago

+1 on this.

The log viewer in v 2.3.X was better suited for ops troubleshooting by having the list of all containers displayed on a left panel. With the new 2.4.X, going through a sub menu to select the container to display the logs is doubling the number of clicks we need to access container logs.