search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.88k stars 5.46k forks source link

UI: Revisit new pod logs containers viewer introduced in v2.4 to get back to a fast single click #10166

Open sharpyy opened 2 years ago

sharpyy commented 2 years ago

Summary

The new pod logs container viewer introduced in argo v2.4 via https://github.com/argoproj/argo-cd/issues/8531 is slowing down operation work when wanting to reviewing quickly all the container logs of a pod. In the previous UI, it was taking a single click to view each container logs. WIth the new UI, it takes one click to go to the list of the containers and a second click to view the container logs. This is making troubleshooting not a efficient as before.

Motivation

The number of clicks required to view the container logs for a particular pods increased by 2 between v2.3 and v2.4. Reducing the number of clicks to a minimum is always best practice.

Proposal

We could probably improve this by replacing the first click to show up the list of containers by a UI rollover method.

pookus commented 2 years ago

+1

alexec commented 1 year ago

Sorry. I closed this, but should not have done that.

alexec commented 1 year ago

fixed?

jsoref commented 10 months ago

In some views, it's possible to see an aggregation from multiple sources, e.g. when looking at a deployment: https://cd.apps.argoproj.io/applications/argo-cd?resource=kind%3APod%2Ckind%3ADeployment&node=apps%2FDeployment%2Fargocd%2Fargocd-repo-server%2F0&tab=logs

image

When looking at a pod that has more than one container, one can only see one container's logs at a time: https://cd.apps.argoproj.io/applications/argo-cd?resource=kind%3APod&node=%2FPod%2Fargocd%2Fargocd-repo-server-568bcd4ff9-5twn6%2F0&tab=logs

image

For certain cases where a pod's containers talk to each other, it'd be really helpful to be able to see the logs from all containers at once.

I can imagine a case where one might only want to view a subset of containers (via a multi-select), so if someone wants to implement a feature where it's a multi-select instead of just an "all / " option, I'd definitely support that.