Eliminate ambiguity by using consistent icons

[Avni-Sharma]

Summary

Some icons on the UI are not well documented or are inconsistent. That leads to ambiguity.

Motivation

On the ArgoCD UI, we see some icons whose purpose/value is not documented or not clearly known. Fixing issues as follows will help in eliminating ambiguity

• For example the tick mark icon and a star on it.
• The to-be-pruned(yellow cross icon) icon seems to be the same as out-of-sync(yellow up arrow icon). In addition, the to-be-pruned icon is not listed as a sync status in the left filter sidebar.

Proposal

If the star icon holds relevance then document it and add a tooltip otherwise maybe removing it is better to avoid confusion. It does not seem feasible to represent the to-be-pruned icon being shown at a sync status place on the resource tile.

priority: high

difficulty: medium (requires some more investigation)

[Avni-Sharma]

Sync failed, imo, should be a part of Sync status

[crenshaw-dev]

For the to-be-pruned icon... what if instead of a circle it were just a yellow X? It'd eliminate the ambiguity with the yellow circular "out of sync" icon?

[glasser]

So does anyone know what the star means?

[druchoo]

So does anyone know what the star means?

That the Pod is "new". I think new is < 30m old.

https://github.com/argoproj/argo-cd/blob/v2.11.0/ui/src/app/applications/components/application-resource-tree/application-resource-tree.tsx#L638