search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.83k stars 5.44k forks source link

Deprecate resource.customizations #11055

Closed reginapizza closed 1 month ago

reginapizza commented 2 years ago

Summary

resource.customizations without subkeys in the argocd-cm should be deprecated in 3.0 milestone. Subkeys were added way back in Argo CD 2.1 (see this PR and blog post announcing the feature). There has been no mention about when it will be deprecated, but as discussed in the argocd contributor's call on Oct 20th, 2022 it should be deprecated.

Proposal

We need to immediately add warnings to impacted code and documentation (currently no recent documentation needs to be fixed since it was removed but documentation for older versions needs to have the warning/note added). Then when the times comes we will need to remove the affected code.

crenshaw-dev commented 2 months ago

I think we can't actually do this and still support glob patterns, since ConfigMap keys can't contain asterisks.