argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.49k stars 5.32k forks source link

Update docs for custom styles to use `sidebar` class #11714

Open fty4 opened 1 year ago

fty4 commented 1 year ago

Description

The UI of Argo CD changed where no .nav-bar class is present anymore. In the new release the class changed to .sidebar.

The documentation still has the old implementation referenced to modify the menu color which can be changed optionally.

The documentation here should be fixed and changed to reference the new sidebar class.

The old color suggestions might not be the best (linear-gradient does not match with Argo CD style anymore?). I would suggest to change it as in this commit here:

https://github.com/fty4/argo-cd/commit/e853963e2ed65c5d15cf6890d775db39cc615adc

Do you agree? Or how should this be changed?


original Argo CD style

Screenshot 2022-12-15 at 10 58 29

Only class change

.sidebar {
  background: linear-gradient(to bottom, #999, #777, #333, #222, #111);
}
Screenshot 2022-12-15 at 10 59 52

class and color change

.sidebar {
  background-color: #444;
}
Screenshot 2022-12-15 at 11 03 25
saumeya commented 1 year ago

Thanks for opening the issue @fty4 , Would you like to contribute these changes to the doc?

fty4 commented 1 year ago

@saumeya I've created a PR (#11733)