search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
16.83k stars 5.1k forks source link

History and Rollback : Don't display details of last deployed revision when opening the screen. #12183

Open lchastel opened 1 year ago

lchastel commented 1 year ago

Summary

In History and Rollback, the details on last deployed revision are displayed. I would like the last deployed revision to be displayed as a summary (like the other ones) when the window is opened.

The user could click on it to have the details.

Motivation

I would like to avoid to scroll to the bottom of the page to see previous deployed revisions. It will be more readable.

Proposal

Display the last deployed version like the other ones.

I attached a screenshot of an application with 2 deployed devisions. I would like the latest revision to be displayed has the second one. 01 02

alexef commented 1 year ago

We have the same issue that the expanded revision details takes too much screen space, making it hard to scroll and find a previous version to rollback.

However, every time this happens, the issue is that all parameters are displayed (not only the overrides).

May I suggest a different solution? Either collapse parameters by default and require an extra click to inspect them OR in Revision and History view show only overriden parameters. WDYT @saumeya ?

saumeya commented 1 year ago

Just looked at the behavior, yes it makes sense to have a default collapsed section and a button to inspect the revision further (if we click on the Revision number it does expand it (however it opens a new tab to the commit)). It would be better to have a separate button to collapse and expand all the details. What are the overridden parameters @alexef, the image tag that was revised from the last revision? But it is maybe good to have all parameters visible

alexef commented 1 year ago

@saumeya in the first screenshot above, the two parameters prefixed with 🔨 are branch and env. All other parameters have the default value, and I wouldn't show them if possible.

saumeya commented 1 year ago

Thanks @alexef , got it. That will be specifically for helm parameters. I am ok with olny showing the overridden parameters or helm could also have a collapsible section as well.

tukak commented 8 months ago

It would be great to see this implemented - we have helm applications with hundreds of parameters and finding the right revision to rollback to is very painful.

jdomag commented 5 months ago

Same here, I need to scroll for 2min to get to second revision.

drileyst commented 1 month ago

Yeah having the first revision collapsed would be a huge improvement.