Layout is more broken in 2.8

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes

https://argo-cd.readthedocs.io

Apache License 2.0

17.9k stars 5.46k forks source link

Layout is more broken in 2.8 #13827

Open n9 opened 1 year ago

n9 commented 1 year ago

Checklist:

[x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
[x] I've included steps to reproduce the bug.
[ ] I've pasted the output of argocd version.

Describe the bug

I have just tried the current master branch. And UI is (more) broken.

To Reproduce

Ideally with narrow screen (e.g. 1200 css px).

Expected behavior

No errors:)

Screenshots

Two vertical scrollbars on left.
Clipped top of the status panel on narrow screens (e.g. 1280 css px).
Minor issue introduced here: https://github.com/argoproj/argo-cd/pull/12068#pullrequestreview-1450594625 (this is not visible in the screenshot above, it is already fixed here: https://github.com/n9/argo-cd/commit/fcb9e18bd2e637f57720202aa2a432df060cedca)

Version

the current master branch

Logs

N/A

n9 commented 1 year ago

Really dirty "solution": https://github.com/n9/argo-cd/commit/cadeb856205019fb15c8d92a1d6c1645eb753386 (and commits after)

(It seems to me that the proper solution might require to refactor argo-ui, which seems to be unmaintained.)

crenshaw-dev commented 1 year ago

argo-ui is... lightly maintained. Would you be up for the refactor work? I have merge permissions on argo-ui.

n9 commented 1 year ago

I think it will be really complex in order not to break other projects. And as I was adding more tweaks to my "fork", it seems to me it will be better to "refractor" (=> rewrite) the styles of argo-ui and ArgoCD from scratch (rethink its architecture).

This is not a good task for a random github contributor.

crenshaw-dev commented 1 year ago

Makes sense! I'll leave it to @keithchong and @rbreeze to decide how to proceed.

n9 commented 1 year ago

One more issue that is not directly related to layout (S)CSS, but FE in general:

New UI is laggy. Not sure whether more laggy than in v2.7 (I was using v2.6 before). So it may be already reported here: https://github.com/argoproj/argo-cd/issues/13768

E.g. deleting a pod lags several (10) seconds:

There is something clearly broken.

crenshaw-dev commented 1 year ago

I'm not good at reading front-end debuggers... can you tell whether the lag is due to front-end problems or slow backend calls?

n9 commented 1 year ago

Frontend.

Someone is trying to mine bitcoins there :) Even totally broken backend cannot freeze frontend (calls are asynchronous).

crenshaw-dev commented 1 year ago

Oh, so it's legit frozen. Might have to do a binary search for the commit, but the biggest front-end change I can think of is the one adding rich YAML editor support.

n9 commented 1 year ago

Now, I have experienced a regular FE crash: https://github.com/argoproj/argo-cd/issues/13856

n9 commented 1 year ago

but the biggest front-end change I can think of is the one adding rich YAML editor support

But this part should not cause lags e.g. after deleting a pod.

Might have to do a binary search for the commit

Does Intuit or Akuity have a FE developer for ArgoCD. They could track the problem much faster in the current state. (Finding the problematic commit might not be useful without knowing how to implement it better.)

crenshaw-dev commented 1 year ago

Akuity has @rbreeze and Red Hat has @keithchong. @ashutosh16 at Intuit is also pretty handy with front-end work.

jsoref commented 2 months ago

fwiw, this appears to have the changes https://github.com/argoproj/argo-cd/compare/release-2.8...n9:argo-cd:patched-2.8.4-1 -- @n9 any plans to make a PR?

n9 commented 2 months ago

any plans to make a PR?

@jsoref These were just hacks to make it somehow usable. Not a real stuff for PR. It seemed to me, that it would require a FE developer who is capable to refactor argo-ui.