argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.33k stars 5.26k forks source link

Make annotation based resource tracking the new default #13981

Open jannfis opened 1 year ago

jannfis commented 1 year ago

Summary

Argo CD should switch the default resource tracking method to the new annotation based resource tracking method.

Motivation

Label based resource tracking has proven to be very limited in the past due to the 63 characters limit of a label's value. The recently introduced annotation based resource tracking has significantly improved resource tracking for a couple of important use cases, e.g.

People used to workaround some of these issue using sync options such as IgnoreExtraneous=true and Prune=false, but this is cumbersome and also not possible in any scenarios.

Proposal

Make annotation based (or even annotation+label) resource tracking the new default. This is a breaking change, therefore it should be changed on a major version bump.

terrytangyuan commented 4 months ago

+1

terrytangyuan commented 2 months ago

I submitted a PR for this for v3.0 to open up some early discussions https://github.com/argoproj/argo-cd/pull/18961