ArgoCD not trimming labels

[michalschott]

Checklist:

• [x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• [x] I've included steps to reproduce the bug.
• [x] I've pasted the output of argocd version.

Describe the bug

In my case ArgoCD uses argocd.argoproj.io/instance: $APP_NAME to track ownership. In case length of $APP_NAME exceeds 63 characters kubernetes refuses to create object.

I believe this should / could be trimmed on ArgoCD level. Currently the only way to bypass this is by trimming $APP_NAME outside of ArgoCD.

To Reproduce

• create app with name longer than 63 characters

Expected behavior

• label values should be trimmed

Screenshots

Version

2.4.28 (have not checked newer versions, might not be related)

Logs

sync error message:

one or more objects failed to apply, reason: Namespace "$APP_NAME" is invalid: metadata.labels: Invalid value: "$APP_NAME": must be no more than 63 characters,namespaces "$APP_NAME" not found (retried 5 times).

[crenshaw-dev]

As far as I can tell, we only truncate labels if you're using annotation+label tracking, not just label. https://github.com/argoproj/argo-cd/blob/master/util/argo/resource_tracking.go#L143-L163

I'm not sure which should be changed, the docs or the implementation. https://argo-cd.readthedocs.io/en/stable/user-guide/resource_tracking/#tracking-kubernetes-resources-by-label

I lean towards changing just the docs. Annotation-based tracking should generally be preferred anyway.

[michalschott]

@crenshaw-dev thanks for explanation, I'll give annotation tracking a go.

[jannfis]

Please also be sure to upgrade to a more recent version :)