jessebot
commented
1 year ago I have tried this as of today, and it unfortunately still doesn't work. I'm using Argo CD v2.8.2+dbdfc71 deployed via the helm chart, and I'm not overriding the image at all. You can see my full values.yaml for the helm chart here as Argo CD manages itself (however the values are in-line yaml because of the valuesObject bug).
Here's an example of a working applicationSet using values: | instead of valuesObject:
https://github.com/small-hack/argocd-apps/blob/380610565cb2681c10d56de8e8a0d771f4cf0cd1/nextcloud/nextcloud_argocd_appset.yaml
And here's the same applicationSet using valuesObject:
https://github.com/small-hack/argocd-apps/blob/9d63a5928a9f0a793b0ebd8b884c146ffc1f1295/nextcloud/nextcloud_argocd_appset.yaml
When using the valuesObject, I see this ComparisonError in the ApplicationConditions when I check the Sync Error via the UI:
Failed to load target state: failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = Manifest generation error (cached): rpc error: code = FailedPrecondition desc = Failed to unmarshal "nextcloud_argocd_appset.yaml":
The same error also appears in the Application controller's pod logs:
{"application":"nextcloud",
"dest-namespace":"nextcloud",
"dest-server":"https://kubernetes.default.svc",
"level":"info",
"msg":"Sync operation to failed: ComparisonError: Failed to load target state: failed to generate manifest for source 1 of 1: rpc error: code = Unknown desc = Manifest generation error (cached): rpc error: code = FailedPrecondition desc = Failed to unmarshal \"nextcloud_argocd_appset.yaml\": \u003cnil\u003e",
"reason":"OperationCompleted",
"time":"2023-09-07T13:21:04Z",
"type":"Warning"}However, none of the pods crashed this time, so the experience is definitely better than last time I tried it :D
crenshaw-dev
Checklist:
argocd version.Describe the bug The ApplicationSet Controller pod seems to get itself into a CrashLoopBackoff state when using a generator (list generator in this case) to populate templated fields in a
spec.template.spec.source.helm.valuesObjectfield. The values I have here work via helm directly in a values file and they also work when I use the ApplcationSet with thespec.template.spec.source.helm.valuesfield instead. They only error when usingvaluesObject, which I know is still pre-release and not officially supported, but is still good to note. In the meantime, the workaround is to just use thehelm.valuesfield instead, for anyone else searching.To Reproduce I tested with a list generator to template a nextcloud helm chart iwth overriden values.
This is the ApplicationSet yaml file (Collapsed by default)
```yaml --- apiVersion: argoproj.io/v1alpha1 kind: ApplicationSet metadata: name: nextcloud-web-app-set namespace: argocd annotations: argocd.argoproj.io/sync-wave: "2" spec: generators: - list: elements: - nextcloudHostname: test.coolwebsite.com template: metadata: name: nextcloud-web-app spec: project: nextcloud destination: server: https://kubernetes.default.svc namespace: nextcloud source: repoURL: 'https://nextcloud.github.io/helm' targetRevision: 3.5.20 chart: nextcloud helm: valuesObject: ingress: enabled: true className: nginx annotations: nginx.ingress.kubernetes.io/proxy-body-size: 10G kubernetes.io/tls-acme: "true" cert-manager.io/cluster-issuer: letsencrypt-staging nginx.ingress.kubernetes.io/enable-cors: "false" nginx.ingress.kubernetes.io/cors-allow-headers: "X-Forwarded-For" nginx.ingress.kubernetes.io/server-snippet: |- proxy_hide_header X-Powered-By; rewrite ^/.well-known/webfinger /index.php/.well-known/webfinger last; rewrite ^/.well-known/nodeinfo /index.php/.well-known/nodeinfo last; rewrite ^/.well-known/host-meta /public.php?service=host-meta last; rewrite ^/.well-known/host-meta.json /public.php?service=host-meta-json; location = /.well-known/carddav { return 301 $scheme://$host/remote.php/dav/; } location = /.well-known/caldav { return 301 $scheme://$host/remote.php/dav/; } tls: - secretName: nextcloud-tls hosts: - "{{nextcloudHostname}}" nextcloud: host: "{{nextcloudHostname}}" existingSecret: enabled: true secretName: nextcloud-admin-credentials usernameKey: username passwordKey: password tokenKey: serverinfo_token smtpUsernameKey: smtpUsername smtpPasswordKey: smtpPassword update: 1 mail: enabled: false configs: logging.config.php: |- 'file', 'logfile' => 'nextcloud.log', 'loglevel' => 1, 'logdateformat' => 'F d, Y H:i:s' ); video_previews.config.php: |- true, 'enabledPreviewProviders' => array ( 'OC\Preview\Movie', 'OC\Preview\PNG', 'OC\Preview\JPEG', 'OC\Preview\GIF', 'OC\Preview\BMP', 'OC\Preview\XBitmap', 'OC\Preview\MP3', 'OC\Preview\MP4', 'OC\Preview\TXT', 'OC\Preview\MarkDown', 'OC\Preview\PDF' ), ); proxy.config.php: |- array( 0 => '127.0.0.1', 1 => '10.0.0.0/8' ), 'forwarded_for_headers' => array('HTTP_X_FORWARDED_FOR'), ); nginx: enabled: true internalDatabase: enabled: false externalDatabase: enabled: true type: postgresql host: localhost:5432 user: nextcloud database: nextcloud existingSecret: enabled: true secretName: nextcloud-pgsql-credentials usernameKey: username passwordKey: nextcloudPassword postgresql: enabled: true global: postgresql: auth: username: nextcloud database: nextcloud existingSecret: nextcloud-pgsql-credentials secretKeys: userPasswordKey: nextcloudPassword adminPasswordKey: postgresPassword volumePermissions: enabled: true primary: podAnnotations: k8up.io/backupcommand: "sh -c 'PGDATABASE=\"$POSTGRES_DB\" PGUSER=\"$POSTGRES_USER\" PGPASSWORD=\"$POSTGRES_PASSWORD\" pg_dump --clean'" k8up.io/file-extension: .sql pgHbaConfiguration: |- local all all trust host all all 127.0.0.1/32 md5 host all nextcloud 10.0.0.0/8 md5 initdb: scripts: my_init_script.sql: | ALTER DATABASE nextcloud OWNER TO nextcloud; GRANT ALL PRIVILEGES ON DATABASE nextcloud TO nextcloud; GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA public TO nextcloud; persistence: enabled: true existingClaim: "nextcloud-postgresql" redis: enabled: false replica: replicaCount: 1 auth: enabled: true existingSecret: nextcloud-redis-credentials existingSecretPasswordKey: redis_password cronjob: enabled: true service: type: ClusterIP port: 8080 loadBalancerIP: nil nodePort: nil persistence: enabled: true existingClaim: nextcloud-files nextcloudData: enabled: false subPath: livenessProbe: enabled: false initialDelaySeconds: 45 periodSeconds: 15 timeoutSeconds: 5 failureThreshold: 3 successThreshold: 1 readinessProbe: enabled: true initialDelaySeconds: 45 periodSeconds: 15 timeoutSeconds: 5 failureThreshold: 3 successThreshold: 1 startupProbe: enabled: false initialDelaySeconds: 30 periodSeconds: 10 timeoutSeconds: 5 failureThreshold: 30 successThreshold: 1 hpa: enabled: false cputhreshold: 60 minPods: 1 maxPods: 10 metrics: enabled: true https: true token: "enabled" timeout: 10s image: tag: 0.6.0 podLabels: jobLabel: nextcloud-metrics service: annotations: prometheus.io/scrape: "true" prometheus.io/port: "9205" labels: jobLabel: nextcloud-metrics serviceMonitor: enabled: true namespace: "nextcloud" rbac: enabled: true syncPolicy: syncOptions: - ApplyOutOfSyncOnly=true automated: prune: true selfHeal: true ``` **Expected behavior** I excepted the applicationSet to produce an application with the templated values rendered. **Version** ```shell argocd: v2.7.10+469f257.dirty BuildDate: 2023-07-31T23:02:18Z GitCommit: 469f25753b2be7ef0905a11632a6382060bcae99 GitTreeState: dirty GoVersion: go1.20.6 Compiler: gc Platform: linux/amd64 WARN[0000] Failed to invoke grpc call. Use flag --grpc-web in grpc calls. To avoid this warning message, use flag --grpc-web. argocd-server: v2.8.0-rc7+1ee5010 BuildDate: 2023-08-03T15:13:16Z GitCommit: 1ee5010d6d55c7a57fd3f3b4f0a8df893d1748bb GitTreeState: clean GoVersion: go1.20.6 Compiler: gc Platform: linux/amd64 Kustomize Version: v5.1.0 2023-06-19T16:58:18Z Helm Version: v3.12.1+gf32a527 Kubectl Version: v0.24.2 Jsonnet Version: v0.20.0 ```If it's helpful, I installed argo-cd via the latest helm chart
argo-cd-5.42.1with a parameter to override the global.image.tag to bev2.8.0-rv7and then patched the ApplicationSet CRD to with the latest at time of writing.Logs These are the logs from the ApplicationSet Controller pod:
As always, I know the maintainers of Argoproj are really busy, but thanks for your continued support and helpfulness :)