Provide ability to hide defined annotations in ArgoCD web UI

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes

https://argo-cd.readthedocs.io

Apache License 2.0

17.87k stars 5.45k forks source link

Provide ability to hide defined annotations in ArgoCD web UI #15693

Closed pasha-codefresh closed 1 week ago

pasha-codefresh commented 1 year ago

Issue Description

We have configured our cluster to run with Docker pull secrets, which creates a secret for each service account (dockercfg).

Normally, ArgoCD hides all secret data using diff.HideSecretData, including the annotation last-applied-configuration (source).

However, when using pull secrets, the dockercfg secret creates an annotation openshift.io/token-secret.value that contains the service account’s access token.

Request

It would be great to have the ability to define a list of annotations that should not be shown in the ArgoCD web UI on the system level. This feature would improve security and privacy for users who are working with secrets and annotations in ArgoCD.

crenshaw-dev commented 1 year ago

A $100 bounty is available for whoever implements this feature!

Bounty details: https://github.com/argoproj/argo-cd/pull/15699/files
Docs to claim a bounty: https://argo-cd.readthedocs.io/en/latest/proposals/feature-bounties/#creating-a-bounty

This is our first feature bounty, so please be patient as we work through the bugs in our system. :-) Bounties will be paid out on Argoproj's behalf by HackerOne and will be subject to the limitations of their payment system.

svghadi commented 4 months ago

Hi @pasha-codefresh , @crenshaw-dev , I have PRs up to implement this functionality. Could you review them? Thanks. https://github.com/argoproj/gitops-engine/pull/577 https://github.com/argoproj/argo-cd/pull/18216

svghadi commented 4 days ago

Hi @crenshaw-dev, the feature implementation is completed. Thanks @pasha-codefresh & @agaudreault for reviews. How do I claim the bounty?