argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.55k stars 5.35k forks source link

Support for 'path' Field in Multiple Sources - Helm Chart and Git Repo #16099

Open meysam81 opened 11 months ago

meysam81 commented 11 months ago

Checklist:

Describe the bug

The path parameter in the second source doesn't work when installing external chart and passing custom values file to it in another ref source.

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: hydra
  namespace: gitops
spec:
  project: ory
  sources:
    - repoURL: https://k8s.ory.sh/helm/charts
      chart: hydra
      targetRevision: 0.36.x
      helm:
        valueFiles:
          - $values/this/path/does/work/hydra-config.yml
          - $values/this/path/does/work/hydra-secret.enc.yml
    - repoURL: "git@github.com:myorg/myrepo.git"
      ref: values
      targetRevision: v1.0.0
      # path: this/path/doesnt/work
  destination:
    server: "https://kubernetes.default.svc"
    namespace: ory

Version

argocd: v2.8.4+c279299
  BuildDate: 2023-09-13T19:43:37Z
  GitCommit: c27929928104dc37b937764baf65f38b78930e59
  GitTreeState: clean
  GoVersion: go1.20.7
  Compiler: gc
  Platform: linux/amd64

Reference

          @meysam81 that would be a second bug, can you open an issue for that?

Originally posted by @crenshaw-dev in https://github.com/argoproj/argo-cd/issues/15764#issuecomment-1755674612

endzyme commented 6 months ago

Running 2.8 and experiencing the same issue, even when the first source has the ref: set, the variable does not contain the path: key in the full variable.

joebowbeer commented 5 months ago

Is this dup of #17262 ?

Current behavior is noted here: https://github.com/argoproj/argo-cd/pull/17431