argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.06k stars 5.51k forks source link

Honor `manifest-generate-paths` when compress tarball for sidecar Config Management Plugin #16837

Open czchen opened 10 months ago

czchen commented 10 months ago

Summary

manifest-generate-paths annotation is used in webhook to eliminate unnecessary trigger of application reconciliation. The logic behind manifest-generate-paths is to list down files that related to the application, and ignore unused files in repository.

The manifest-generate-paths, however, does not help in sidecar config management plugin. In sidecar case, the git repository, excluding reposerver.plugin.tar.exclusions, is compressed and sent to sidecar to generate application resources, even when some of the contents in git repository are not needed.

Motivation

When using monorepo, there are lots of applications depends on single git repository, and each application only use small subset of files. With manifest-generate-paths, only files needed by application are sent to sidecar to reduce unnecessary compression/decompression.

Proposal

jsolana commented 1 month ago

Can we close this issue? Cause it is covered by https://github.com/argoproj/argo-cd/pull/19209