argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.95k stars 5.47k forks source link

ArgoCD UI doesn't pass plugin's parameters correctly #17265

Open ctxch opened 9 months ago

ctxch commented 9 months ago

Describe the bug

As you can see in the picture below the ArgoCD UI sends only the first char of the value of the parameter if there is more than 1 parameter defined.

To Reproduce

Create the following plugin

---
apiVersion: v1
kind: ConfigMap
metadata:
  name: installator-plugin
data:
  plugin.yaml: |
    apiVersion: argoproj.io/v1alpha1
    kind: ConfigManagementPlugin
    metadata:
      name: installator-plugin
    spec:
      version: v0.1
      init:
        command: ['/opt/argocd/argocd_init.sh']
      generate:
        command: ['/opt/argocd/argocd_generate.sh']
      discover:
        find:
          command: [sh, -c, find . -name configuration.yml]
      parameters:
        static:
        - name: installator-secrets-key
          required: false
          title: SECRETS KEY
        - name: installator-config-set
          required: false
          title: CONFIG-SET

Create a new application and inspect the payload in your browser.

Screenshots

argocd-payload

Version

v2.10.1+a79e0ea
Killpit commented 7 months ago

Did you tried removing v1alpha1? Because it can cause confusion instead of v1?

ctxch commented 7 months ago

Do you mean in the ConfigManagementPlugin manifest? Yes, I did - The same result.

Killpit commented 7 months ago

Did you check connectivity using kubectl and checking API connection with kubectl cluster-info?

ctxch commented 7 months ago

Yep, everything works like a charm if just one plugin parameter is defined. I mean, it also works with more parameters but it just does not pass the value properly as mentioned in the issue description.

andrii-korotkov-verkada commented 6 days ago

ArgoCD versions 2.10 and below have reached EOL. Can you upgrade and let us know if the issue is still present, please?