When ServerSideDiff is enabled, modifying a service or container port number results in "duplicate" error. Diff cannot complete.

[avo-sepp]

Checklist:

• [x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• [x] I've included steps to reproduce the bug.
• [x] I've pasted the output of argocd version.

Describe the bug

When ServerSideDiff BETA is enabled, changing the pod or service port number without changing the name of the port results in an error stating duplicate "port name". The expected behavior would be that the port is overwritten by apply.

To Reproduce

Deploy a pod and service with ArgoCD, enable ServerSideDiff beta for ArgoCD. Then try and change just the port number for the service + container without changing the name of the port/service.

Expected behavior

ArgoCD should rewrite the Pod/Container and Service with the updated pod number.

Version

argocd: v2.10.4+f5d63a5.dirty BuildDate: 2024-03-18T09:28:41Z GitCommit: f5d63a5c77d2e804e51ef94bee3db441e0789d00 GitTreeState: dirty GoVersion: go1.22.1 Compiler: gc Platform: darwin/arm64 argocd-server: v2.10.5+335875d BuildDate: 2024-03-28T15:02:45Z GitCommit: 335875d13e018bed6e03873f4742582582964745 GitTreeState: clean GoVersion: go1.21.3 Compiler: gc Platform: linux/amd64 Kustomize Version: v5.2.1 2023-10-19T20:13:51Z Helm Version: v3.14.3+gf03cc04 Kubectl Version: v0.26.11 Jsonnet Version: v0.20.0

Screenshots

Logs

Failed to compare desired state to live state: failed to calculate diff: error calculating server side diff: serverSideDiff error: error running server side apply in dryrun mode for resource Deployment/workerservice-prod-uc-http-service: Deployment.apps "workerservice-prod-uc-http-service" is invalid: spec.template.spec.containers[0].ports[1].name: Duplicate value: "http"

[avo-sepp]

Just for FYI, Force and Replace did not fix the issue in ArgoCD. I had to manually delete the service in Kubernetes. Not a possibility for production systems.

[klemmster]

This also happens when changing the port name, not the number

[zswanson]

Verified having this issue. Moreover, deleting the 'conflicting' object is only a 1 time fix. It continues to happen on every sync.

[BarAshkenazi]

Confirming that I was able to reproduce this issue as well on version 2.12.3, a fix will be beneficial

[NiklasRosenstein]

Same here, I was about to update Immich on my server, they changed the port number. Instead of replacing the ports entirely, the new item is appended ...? I don't see how this would be intentional semantics.

I also have the same issue for a Deployment's container's ports list (also in Immich, same port number change).

[andrii-korotkov-verkada]

ArgoCD versions 2.10 and below have reached EOL. Can you upgrade and tell us if the issue is still present, please?

[BarAshkenazi]

@andrii-korotkov-verkada I was able to reproduce this issue as well on version 2.12.3