argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18k stars 5.48k forks source link

Argo CD Dex with OpenShift integration possible? #17977

Open JensBammens opened 7 months ago

JensBammens commented 7 months ago

Checklist:

Describe the bug

Operator release 0.9.1 does not function with Argo CD Dex. Is the OpenShift integration compatible with the static client? When we leave out connectors: [] it results in an invalid Dex config.

To Reproduce

spec:
  sso:
    dex:
      config: |
        staticClients:
        - id: argo-workflows-sso
          name: Argo Workflow
          secretEnv: ARGO_WORKFLOWS_SSO_CLIENT_SECRET
          redirectURIs:
            - https://argoworkflows.example.com/oauth2/callback
      env:
        - name: ARGO_WORKFLOWS_SSO_CLIENT_SECRET
          valueFrom:
            secretKeyRef:
              key: client-secret
              name: argo-workflows-sso
      openShiftOAuth: true
    provider: dex

  additionalConfig:
    dex.config: |
      logger:
        level: debug
        format: json
      connectors: []
      staticClients:
      - id: argo-workflows-sso
        name: Argo Workflow
        secretEnv: ARGO_WORKFLOWS_SSO_CLIENT_SECRET
        redirectURIs:
          - https://argoworkflows.example.com/oauth2/callback

Expected behavior

Authentication should remain functional for OpenShift and there should be a static client available.

Screenshots

Version

v2.10.5+335875d

Logs

Paste any relevant application logs here.
andrii-korotkov-verkada commented 1 week ago

ArgoCD versions 2.10 and below have reached EOL. Can you upgrade and tell us if the issue is still present, please?