argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
16.33k stars 4.93k forks source link

fix(ui): consistent resource menu across views (#18060) #18069

Closed agaudreault closed 1 week ago

agaudreault commented 2 weeks ago

Closes https://github.com/argoproj/argo-cd/issues/18060

Changes

Non-visible changes:

Description Before After
Consistent Menu Items: Tree view image image
Consistent Menu Items: Tree view (Grouped) image image
Consistent Menu Items: Pods view image image
Consistent Menu Items: Network view image image
Consistent Menu Items: Network view (Grouped) image image
Consistent Menu Items: List view image image
Delete popup broken Force Delete checkbox display image image
List view display with multiple kinds image image
List view display single kind with same parent image image
Only have sync action on managed resources image image
Highlight the deleted resource type image image
Add Icon to Applciation list actions image image
Application delete menu in Red image image

See it in action

https://github.com/argoproj/argo-cd/assets/47184027/deee9574-3010-4622-8176-e7d2dff6c31d

Checklist:

wanghong230 commented 2 weeks ago

Amazing details! Unfortunately, I am not entitled to review the UI code, so I cannot just approve the PR.