argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
16.33k stars 4.93k forks source link

chore(ui-dev): migrate `tslint` to `eslint` (#11652) #18079

Closed Marvin9 closed 1 week ago

Marvin9 commented 2 weeks ago

fixes #11652

This PR

Checklist:

crenshaw-dev commented 1 week ago

This is awesome. I notice a huge part of the diff is just trailing commas. Would it be possible to remove that lint rule to make the diff more readable? We can always have a follow-up PR to make that change.

I didn't read too far, but I'd recommend taking that route for any rules which have changed a lot of lines.

Marvin9 commented 1 week ago

Sorry forgot to explain the reason for the commas (why wasn't there before).

When I bumped the prettier version from 1 -> 3, the default configuration was probably changed. Thus with this new version, we need to explicitly state that we don't want trailing commas.

crenshaw-dev commented 1 week ago

Makes sense! I'm also up to change that config if people want, just better to be in a standalone PR.