argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
16.45k stars 4.97k forks source link

fix: app names with non-alphanumeric characters in position 63 break syncs (issue #18237) #18256

Closed RobinsonZ closed 1 week ago

RobinsonZ commented 2 weeks ago

Fixes #18237. Fixes #10110.

Checklist:

jannfis commented 2 weeks ago

This seems trying to fix the same issue as https://github.com/argoproj/argo-cd/pull/17560

RobinsonZ commented 2 weeks ago

Seems so. That PR looks stale but I will defer to maintainers as to which version you would like to go with. This is actively biting us, and workarounds are tricky for a variety of reasons, so whatever gets the issue fixed is fine by me.

RobinsonZ commented 2 weeks ago

@jannfis Updated per your feedback. Let me know if any other changes are needed.

RobinsonZ commented 4 days ago

Can this be cherry-picked into 2.11?

pasha-codefresh commented 4 days ago

/cherry-pick release-2.11