argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.46k stars 5.3k forks source link

otelgrpc package should use interceptors in favor of stats handlers #18258

Open 34fathombelow opened 4 months ago

34fathombelow commented 4 months ago

Summary

Otelgrpc dependency (go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc) >= v0.46.0 has deprecated the use of StreamServerInterceptor, UnaryServerInterceptor, and StreamClientInterceptor. Migrating to stats handlers should be performed in a future release of Argo CD to guarantee backwards compatability.

Jack-R-lantern commented 4 months ago

@34fathombelow

I'm a new contributor. If this is not too difficult, could you assign it to me?

blakepettersson commented 4 months ago

@Jack-R-lantern feel free to take this task - this has been worked on in #17790, but is currently failing the E2E tests...