Open runofthemill opened 4 months ago
related #18239
I built the docs locally with mkdocs directly to investigate
python3 -m venv /tmp/argocd
source /tmp/argocd/bin/activate
pip install -r docs/requirements.txt
# Install mkdocs if you don't have it, on macOS: brew install mkdocs
mkdocs serve
The version selector was fixed in #18239, but the banner still exists when on stable. It looks like selecting stable
does not actually load the stable docs, since the URL is /stable
, but the version selector shows latest
.
Also, I noticed that the 2.10 and 2.11 releases are completely missing from the version selection.
Checklist:
argocd version
.This may be an RTD bug/change, but the docs are showing this warning in the header:
You are viewing the docs for an unreleased version of Argo CD
Screenshot shows the version selected is older, and correctly shows a modal indicating that, but regardless of the selected version, the top banner is present.
Also notable is the window object
READTHEDOCS_DATA
which is used in the version check is undefined, making me think it may be a change from RTD.To Reproduce
Visit https://argo-cd.readthedocs.io/en/stable or select any other version
Expected behavior
Only show
You are viewing the docs for an unreleased version of Argo CD
when viewing https://argo-cd.readthedocs.io/en/latest/.Screenshots
Version
N/A
Logs
N/A