argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.86k stars 5.45k forks source link

Containers in pods with native sidecars don't show as "ready" #18725

Closed adamwilner closed 3 weeks ago

adamwilner commented 4 months ago

Checklist:

Describe the bug In the tree view, pods with one or more native sidecars show all containers as not ready i.e. 0/2, even if they are.

To Reproduce Define a Deployment with at least one container set up as a native sidecar and sync. When synced none of the containers in any of the resulting pods will appear ready.

Expected behavior Pods in the tree view would show that containers are ready if they are.

Screenshots

Argocd

image

Kubectl

image

Version

v2.11.3+3f344d5

Logs

Paste any relevant application logs here.
booleanbetrayal commented 4 months ago

Would love to have native sidecar support working in ArgoCD as that K8s feature would simplify a few things in our manifests. Wouldn't mind trying a stab at contributing either, but not sure the best place to start looking into this. Is this downstream of some healthcheck code, etc?

Hronom commented 2 months ago

Pretty important thing if you use popular service meshes like Istio. Otherwise it display wrong information.

linghaoSu commented 2 months ago

could I take this?

alexef commented 2 months ago

go for it. here is the corresponding similar issue in Kubernetes Dashboard (with attached PR): https://github.com/kubernetes/dashboard/issues/9299 checking where in ArgoCD code we have a similar logic

alexef commented 2 months ago

this is actually here: https://github.com/argoproj/argo-cd/blob/master/controller/cache/info.go#L310 @linghaoSu let me know if you need help with the PR

blevz commented 4 weeks ago

Any updates on this? We are getting bitten pretty badly by this