search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.14k stars 5.21k forks source link

Dark Mode: Collapsed sections color is white #18742

Open Sayrus opened 2 months ago

Sayrus commented 2 months ago

Checklist:

Describe the bug

When a property in the summary overflows, the section is collapsed by default. The white color is hardcoded here.

On the white theme, there is no gradient overflow indicator and only the arrow is used.

To Reproduce

  1. Any component with several annotations will show a collapsed section.
  2. Open the component summary

Expected behavior

Either:

  1. Gradient fades to dark gray rather than white
  2. No gradient (But that may impact other components who rely on the white gradient)

Using light-argo-gray-2 gives the following: image image

Disabling the gradient gives the following: image

Screenshots

image image

Version

argocd-server: v2.10.9+c071af8
  BuildDate: 2024-04-30T15:53:28Z
  GitCommit: c071af808170bfc39cbdf6b9be4d0212dd66db0c
  GitTreeState: clean
  GoVersion: go1.21.3
  Compiler: gc
  Platform: linux/amd64
  Kustomize Version: v5.2.1 2023-10-19T20:13:51Z
  Helm Version: v3.14.3+gf03cc04
  Kubectl Version: v0.26.11
  Jsonnet Version: v0.20.0

Logs

N/A

surajyadav1108 commented 2 months ago

I would say to keep the gradient as white but increase the gray percentage

Screenshot 2024-06-21 103720

wdyt @Sayrus

shijiadong2022 commented 1 month ago

I'd like to work on this one.

shijiadong2022 commented 1 month ago

@surajyadav1108 can you share the reason to keep the gradient as white? It looks still not a clean UI with the change. Any concerns if we remove the gradient background for both light and dark theme?

surajyadav1108 commented 1 month ago

@surajyadav1108 can you share the reason to keep the gradient as white? It looks still not a clean UI with the change. Any concerns if we remove the gradient background for both light and dark theme?

It is a highlight for the dropdown, and since it is a shared component, removing it might not be ideal. However, if you prefer it removed, then please do so specifically for this part

shijiadong2022 commented 1 month ago

Thanks. I will keep the gradient as white as it is a shared component.