search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
16.74k stars 5.07k forks source link

Add pull request state to the github pull request generator #18779

Open bery opened 2 weeks ago

bery commented 2 weeks ago

Summary

Add a pull request state to the github pull request generator to add the ability to generate applications for all github PR statuses - all, opened or closed. To preserve backwards compatibility, applications should be generated only for opened pull requests.

Motivation

To be able to generate applications using argoCD for both opened and closed pull requests, the same functionality is already present for Gitlab pull request generator.

Proposal

Exactly the same way as for Gitlab pull request generator - by default create applications only for opened PRs on github but allow to filter the PRs by the state attribute to all, opened or closed.

bery commented 1 week ago

If approved, I'm willing to provide the PR.

agaudreault commented 1 week ago

Seems reasonable to provide feature parity. 👍

christianh814 commented 1 week ago

+1 from me, good to have similar functionality across providers