search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.91k stars 5.46k forks source link

Support git webhook on Applicationsets for gitea/forgejo #18798

Open lyz-code opened 4 months ago

lyz-code commented 4 months ago

Summary

Git webhook seems to only be supported for Applications when using gitea/forgejo but we need it for applicationsets

Motivation

Not having to wait 3 minutes for argocd to refresh the repositories when Applicationsets and gitea/forgejo

Proposal

Adapt the existent code for applications to applicationsets

vfaergestad commented 4 months ago

Not saying the motivation is not justified anyway, but just want to mention that you can add spec.generators[i].requeueAfterSeconds to change the interval that ArgoCD uses to refresh the repositories.

christianh814 commented 4 months ago

+1 for me as we should have feature parity

robinlieb commented 3 months ago

Could offer to work on that, but currently have two PRs open (#15443 / #16303) which I love to get merged before to avoid introducing merge conflicts. Generally thought about bringing implementations of application and appset webhooks closed in a util package to avoid these feature imparity in future.