argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes

https://argo-cd.readthedocs.io

Apache License 2.0

16.7k stars 5.06k forks source link

BitBucket server pullrequest generator accesToken authentication #18845

Open appiepollo14 opened 4 days ago

appiepollo14 commented 4 days ago

Summary

As is possible for BitBucket cloud, I would like to be able to authenticate using an accesstoken when using the pullrequest generator in combination with BitBucket server.

Motivation

I don't want to use basic auth for the BitBucket server pullrequest generator. The same functionality is already present for BitBucket cloud pull request generator.

Proposal

Apply the same code as for BitBucket cloud, to the BitBucket server configuration at the pullrequest generator config code.

appiepollo14 commented 4 days ago

W'ld love to provide a PR, please let me know whether to proceed.

christianh814 commented 4 days ago

@appiepollo14 Feel free to submit a PR and reference this issue.

appiepollo14 commented 2 days ago

@christianh814 provided a PR, can you review it or who does that for argoproj?

christianh814 commented 1 day ago

@appiepollo14 I'll take a look but it might be worth dropping in the Argo CD/Rollouts contributors office hours

appiepollo14 commented 1 day ago

Thanks @christianh814 for your reply. What do you mean by the link / office hours? Do I need to drop this pr somewhere or...?