search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
16.77k stars 5.08k forks source link

Add `discovery.k8s.io/EndpointSlice` to `ignoredRefreshResources` to skip app requeueing #18857

Open andrii-korotkov-verkada opened 1 week ago

andrii-korotkov-verkada commented 1 week ago

Summary

Currently /Endpoints are skipped when trying to trigger a reconciliation (link). I think discovery.k8s.io/EndpointSlice should be added to the list as well for the same reasons. Also, skipResourceUpdate should be done after skipAppRequeuing check for optimization.

Motivation

Do an additional optimization to reduce reconciliations. Other resources like pods would already trigger reconciliations when there are relevant updates.

Proposal

Just update the dictionary of ignoredRefreshResources mentioned above to include the entry for discovery.k8s.io/EndpointSlice

AnkurManna commented 1 week ago

If approved, I'm willing to provide the PR.

AnkurManna commented 1 week ago

Please review https://github.com/argoproj/gitops-engine/pull/596, as only after merging this i will be able to use these changes in argo-cd repo like https://argo-cd.readthedocs.io/en/stable/developer-guide/dependencies/ for the final pr.