UI - Dark theme background on Application Details panel page

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes

https://argo-cd.readthedocs.io

Apache License 2.0

17.24k stars 5.23k forks source link

UI - Dark theme background on Application Details panel page #19094

Open shijiadong2022 opened 1 month ago

shijiadong2022 commented 1 month ago

Checklist:

[ ] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
[ ] I've included steps to reproduce the bug.
[ ] I've pasted the output of argocd version.

Describe the bug

To Reproduce

1, Change system to Dark Theme in Settings page 2, Go to Applications page 3, Select one of the applications 4, Click DETAILS to view application details panel page 5, Notice the background of Annotation

Expected behavior

shijiadong2022 commented 1 month ago

I am working on a fix and will submit a PR soon

surajyadav1108 commented 1 month ago

Duplicate #18742

shijiadong2022 commented 1 month ago

@alexmt in issue #18742 the suggested solution is to increase the gray percentage. It seems to me that we can also remove the background setting in expandable.scss without any impact to both light and dark theme. background: linear-gradient(to bottom, rgba(255,255,255,0) 0%,rgba(255,255,255,1) 100%); Any recommendation on which solution works better for this case?