Describe the bug
I am using PullRequest generator for ApplicationSet with Github. I did setup webhook for applicationset via another ingress per the note mentioned in applicationset webhook configuration.
My github host doesn't has a port, but the regex used in ArgoCD expects a colon followed by a port number as in :443. Without that, my webhook is not processed and PullRequest generator waits for time defined in requeueAfterSeconds parameter. The colon and port part of the regex after hostname should be optional and work without providing colon and port number.
Create a PullRequest Generator applicationset using api:
Create a webhook from github for applicationset ingress resource. This is different from argocd-server ingress. If you do not configure ingress for applicationset then webhook will deliver to argocd-server
Create a PullRequest which will trigger an event in applicationset
Expected behavior
A refresh should happen in the application that is controlled by my applicationSet and show below message in logs
time="2024-07-22T18:12:20Z" level=info msg="refresh ApplicationSet kube-argocd/aws-ebs-csi-driver from webhook"
update api parameter to api: https://github.corp.redacted.com:443
Update applicationSet via kubectl apply -f <filename>
Create a Pull Request which will trigger an event in applicationSet.
Logs
This is what I see when I don't use :443 for api parameter in pullRequest generator. This happens for all pull request events
time="2024-07-22T18:00:23Z" level=debug msg="https://github.corp.redacted.com does not match (?i)([http://|https://|\\w+@|ssh://(\\w+@)](about:blank)?)github.corp.redacted.com(:[0-9]+|)[:/]"
Once :443 is added to my github host and updated applicationset, I see the following in the logs.
Checklist:
argocd version
.Describe the bug I am using PullRequest generator for ApplicationSet with Github. I did setup webhook for applicationset via another ingress per the note mentioned in applicationset webhook configuration. My github host doesn't has a port, but the regex used in ArgoCD expects a colon followed by a port number as in
:443
. Without that, my webhook is not processed and PullRequest generator waits for time defined in requeueAfterSeconds parameter. The colon and port part of the regex after hostname should be optional and work without providing colon and port number.My Github host: https://github.corp.redacted.com Regex expected github host: https://github.corp.redacted.com:443 To Reproduce
Expected behavior A refresh should happen in the application that is controlled by my applicationSet and show below message in logs
Screenshots
Version
To fix the problem:
api: https://github.corp.redacted.com:443
kubectl apply -f <filename>
Logs
This is what I see when I don't use :443 for api parameter in pullRequest generator. This happens for all pull request events
Once :443 is added to my github host and updated applicationset, I see the following in the logs.