search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.8k stars 5.43k forks source link

hydrator(ui): show hydration status in applications list #19494

Open crenshaw-dev opened 2 months ago

crenshaw-dev commented 2 months ago

We should show the hydrator status in the Application list for each app card:

image

I think the order should be "Healthy, Hydrated, Synced".

nueavv commented 2 months ago
스크린샷 2024-08-20 오전 8 57 43

I've made some changes, but it seems like the UI alignment might be off. Could you take a look at the screenshot and let me know if there's anything that needs adjustment?

keithchong commented 1 month ago

Hi @nueavv , are you still working on this?

crenshaw-dev commented 1 month ago

@keithchong it's still WIP, it's waiting on my review

keithchong commented 1 month ago

Ok cool...I was looking at some of the hydrator issues. @nueavv, regarding your question and screenshot above, I think the list view 'rows' should all be the same height.

nueavv commented 1 month ago

Ok cool...I was looking at some of the hydrator issues. @nueavv, regarding your question and screenshot above, I think the list view 'rows' should all be the same height.

The difference in height is due to whether the hydrator is turned on or off. Do you think it would be better to add an extra row even when it's turned off?

keithchong commented 1 month ago

@nueavv, I think the approach is that each card should be a fixed height, considering that the each card contains application info, so it should be 'consistent' or homogenous representation across each row. But, having the extra empty space across the bottom of the card will look odd.

Perhaps try to centre-align vertically the row contents, or just centre-align the first five or so columns? Everything looked balanced before.

nueavv commented 1 month ago

@keithchong hmm.. I agree. But Since I’m not very familiar with UI modifications, could you help me figure out the best approach? Once this PR is merged, I’m also okay with someone else fixing it afterward if needed.