Open reggie-k opened 3 months ago
The websocket functionality for pod exec needs further unit testing and e2e testing.
Currently only the surrounding functionality is being tested (such as permission validation, testing server connection, etc)
Unit tests for read and write: https://github.com/argoproj/argo-cd/blob/master/server/application/websocket.go#L163 https://github.com/argoproj/argo-cd/blob/master/server/application/websocket.go#L213
New e2e tests are also needed.
The PR for this should be prefixed with test:
test:
Hi, I'd like to take this up. Can you provide me answers for a couple of questions here:
Summary
The websocket functionality for pod exec needs further unit testing and e2e testing.
Motivation
Currently only the surrounding functionality is being tested (such as permission validation, testing server connection, etc)
Proposal
Unit tests for read and write: https://github.com/argoproj/argo-cd/blob/master/server/application/websocket.go#L163 https://github.com/argoproj/argo-cd/blob/master/server/application/websocket.go#L213
New e2e tests are also needed.
The PR for this should be prefixed with
test: