argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.45k stars 5.3k forks source link

Adding Health Checks for cluster api MachinePool #19596

Open afarbos opened 4 weeks ago

afarbos commented 4 weeks ago

Summary

Support Health checks for cluster api Machine Pool CRD. https://cluster-api.sigs.k8s.io/tasks/experimental-features/machine-pools

Motivation

This is a way to increase current coverage with common use cases of using managed cluster with a managed pool: eks cluster with eks node groups...

Proposal

How do you think this should be implemented? https://github.com/argoproj/argo-cd/pull/19595

christianh814 commented 3 weeks ago

+1, especially since people are using Cluster API + Argo CD in a lot of situations