Absence of source and sources in Application cause an unavailability of web interface, which shows stacktrace

[BoyFromDubai]

Checklist:

• [ ] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
• [ ] I've included steps to reproduce the bug.
• [ ] I've pasted the output of argocd version.

Describe the bug When you create an application without source and sources the Web UI is not accessible, showing the stacktrace

To Reproduce Deploy smth like this

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: smth
  namespace: argocd
spec:
  destination:
    namespace: xxx
    name: in-cluster
  project: default

Expected behavior

An existence of sources or source must be validated or just give to an app an unknown status in the WebUI

Screenshots

Version

v2.11.2

But tested in v2.12.x also, and if I'm not mistaken, the same issue exists

[lsq645599166]

In the web ui，using the yaml above，it'll throw an error of "source is required".

I wonder if it would be more convenient to limit spec.source field to be required in the CRD.

[BoyFromDubai]

Yes, but there is an alternative which is “sources” for using multiple sources within one app. That’s why “required” was not used in CRD I suppose

[lsq645599166]

Oh sorry, I forgot this situation

[lsq645599166]

how about oneOf, we can require source/sources at least one required

refer: https://kubernetes.io/blog/2019/06/20/crd-structural-schema/#structural-schema

[BoyFromDubai]

Maybe, sounds suitable But I’m not good at CRDs actually