argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
17.71k stars 5.4k forks source link

Graph lines disappears at lower zoom levels (component:ui) #20365

Open krokofant opened 4 days ago

krokofant commented 4 days ago

Checklist:

Describe the bug The graph lines between the graph nodes should be visible at different zoom levels.

To Reproduce Open an app that contains a resource tree like a deployment and use the argo zoom controls to zoom out. image

Expected behavior The graph lines should be visible.

Screenshots image image image

Version

argocd-server: v2.12.3+6b9cd82
  BuildDate: 2024-08-27T11:57:48Z
  GitCommit: 6b9cd828c6e9807398869ad5ac44efd2c28422d6
  GitTreeState: clean
  GoVersion: go1.22.4
  Compiler: gc
  Platform: linux/amd64
  Kustomize Version: v5.4.2 2024-05-22T15:19:38Z
  Helm Version: v3.15.2+g1a500d5
  Kubectl Version: v0.29.6
  Jsonnet Version: v0.20.0

Logs

Paste any relevant application logs here.
krokofant commented 4 days ago

Part solution for the css is tree line transform needs to implement counter scaling like scale(calc(1/${props.zoom})). But then placement and/or width/height is a bit off image

linghaoSu commented 4 days ago

I'm interested in this. Could I take it up?

krokofant commented 4 days ago

@linghaoSu If you're asking me then yes 😁

linghaoSu commented 4 days ago

The rendering behavior appears to vary across browsers. Testing revealed the following:

linghaoSu commented 3 days ago

Hi @krokofant,

Could you let me know which browser, version you're using?

krokofant commented 2 days ago

Hi @krokofant,

Could you let me know which browser, version you're using?

I forgot that crucial information. I'm using Firefox Developer Edition (latest/probably 132.0beta, can't check now) on macOS. Tested on a 1440p monitor.