argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.01k stars 5.49k forks source link

feat(AppProject): Add sync window description #20766

Open speedfl opened 1 week ago

speedfl commented 1 week ago

Closes [#20723]

Checklist:

image image

apiVersion: argoproj.io/v1alpha1
kind: AppProject
metadata:
  creationTimestamp: "2024-04-17T19:11:34Z"
  generation: 4
  name: gpg
  namespace: argocd-e2e
  resourceVersion: "3198389"
  uid: 44474152-edb7-4c40-adff-e04c5c2b3d90
spec:
  clusterResourceWhitelist:
  - group: '*'
    kind: '*'
  destinations:
  - namespace: '*'
    server: '*'
  signatureKeys:
  - keyID: D56C4FCA57A46444
  sourceNamespaces:
  - argocd-e2e-external
  sourceRepos:
  - '*'
  syncWindows:
  - applications:
    - aaa-*
    description: Ticket 123456
    duration: 57m
    kind: deny
    schedule: '* * * * *'
    timeZone: UTC
  - applications:
    - bbbb-*
    duration: 58m
    kind: allow
    schedule: '* * * * *'
    timeZone: UTC
status: {}
bunnyshell[bot] commented 1 week ago

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

OpenGuidou commented 1 week ago

LGTM !

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.

Project coverage is 55.21%. Comparing base (993d79c) to head (9f449a3). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/projectwindows.go 0.00% 3 Missing :warning:
pkg/apis/application/v1alpha1/types.go 62.50% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20766 +/- ## ========================================== - Coverage 55.21% 55.21% -0.01% ========================================== Files 324 324 Lines 55256 55266 +10 ========================================== + Hits 30508 30513 +5 - Misses 22133 22134 +1 - Partials 2615 2619 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

neith00 commented 1 week ago

I feel like this field should be limited in length. What about 64 or 255 Bytes?