search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18.01k stars 5.49k forks source link

Fix flaky test `TestFormatConditionSummary/Few_conditions_are_defined` #20847

Closed crenshaw-dev closed 5 days ago

crenshaw-dev commented 5 days ago 
=== Failed
=== FAIL: cmd/argocd/commands TestFormatConditionSummary/Few_conditions_are_defined (0.00s)
    app_test.go:494: 
            Error Trace:    /home/runner/work/argo-cd/argo-cd/cmd/argocd/commands/app_test.go:494
            Error:          Not equal: 
                            expected: "type1(2),type2"
                            actual  : "type2,type1(2)"

                            Diff:
                            --- Expected
                            +++ Actual
                            @@ -1 +1 @@
                            -type1(2),type2
                            +type2,type1(2)
            Test:           TestFormatConditionSummary/Few_conditions_are_defined
            Messages:       Incorrect summary "type2,type1(2)", should be type1(2),type2
devopsjedi commented 5 days ago

I would like to work on this issue.

crenshaw-dev commented 5 days ago

@devopsjedi sure, give it a whirl!

crenshaw-dev commented 5 days ago

@devopsjedi it was causing trouble on PRs, so I went ahead and opened a fix.

crenshaw-dev commented 5 days ago

Fixed by https://github.com/argoproj/argo-cd/pull/20759