argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18k stars 5.48k forks source link

fix: Fix repeated 403 due to app namespace being undefined (#20699) (cherry-pick #20819) #20860

Closed gcp-cherry-pick-bot[bot] closed 1 day ago

gcp-cherry-pick-bot[bot] commented 2 days ago

Cherry-picked fix: Fix repeated 403 due to app namespace being undefined (#20699) (#20819)

Fixes #20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use this.props.match.params.appnamespace could also fail if it's undefined. As a fix, create and use a helper function getAppNamespace which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov andrii.korotkov@verkada.com