argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18k stars 5.48k forks source link

feat: allow for specifying pre-release in regex #20862

Open Spazzy757 opened 1 day ago

Spazzy757 commented 1 day ago

This PR allows for checking for pre-release specific tags

previously in the case of having a pre-release (i.e v1.0.*-rc) the git check would ignore the pre-release versions and just do the latest tag (i.e v1.0.1) which could be a different release entirely.

NOTE: My assumption is that this is only valid with wildcards as I dont think something like < v1.2.*-rc would be a valid constraint, but if this is incorrect please let me know

I am not entirely sure if this is considered a bug fix or a feature

Related Issue: https://github.com/argoproj/argo-cd/issues/18899

Related Discussion: https://github.com/argoproj/argo-cd/discussions/20595

would be great to have this patched in v2.12

Checklist:

bunnyshell[bot] commented 1 day ago

:exclamation: Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.06%. Comparing base (3b81d3c) to head (0c85079).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #20862 +/- ## ========================================== + Coverage 55.02% 55.06% +0.03% ========================================== Files 324 324 Lines 55413 55423 +10 ========================================== + Hits 30492 30517 +25 + Misses 22306 22295 -11 + Partials 2615 2611 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.