search

argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18k stars 5.48k forks source link

fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133) #20872

Open eestolano opened 1 day ago

eestolano commented 1 day ago

fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133)

eestolano commented 1 day ago

This is a manual cherry-pick because gcp-cherry-pick-bot didn't pick up the /cherry-pick release-2.11, /cherry-pick release-2.12, and /cherry-pick release-2.13 comments in https://github.com/argoproj/argo-cd/pull/18133.

(This is my first time filing a PR against Argo CD; please let me know if I need to adjust anything. If and when it's approved, I'll create the equivalent PRs for 2.11 and 2.12.)

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.04%. Comparing base (af54ef8) to head (fcc6d87).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-2.13 #20872 +/- ## ================================================ + Coverage 55.01% 55.04% +0.03% ================================================ Files 320 320 Lines 54735 54743 +8 ================================================ + Hits 30111 30136 +25 + Misses 22045 22035 -10 + Partials 2579 2572 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

crenshaw-dev commented 1 day ago

codegen is expected to fail, only other thing to knock out is DCO. Can you fix that check?

eestolano commented 1 day ago

I'm not sure what to do about this DCO check failure -- it looks like the original author's Github email address has changed, and no longer matches the signoff on the original commit:

Commit sha: fcc6d87, Author: Tony Au-Yeung, Committer: Esteban Molina-Estolano; Can not find "Tony Au-Yeung tonyay163@gmail.com", in ["Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io", "Tony Au-Yeung tony@elevenlabs.io"].

Should I add my own sign-off to the end of the commit message?