argoproj / argo-cd

Declarative Continuous Deployment for Kubernetes
https://argo-cd.readthedocs.io
Apache License 2.0
18k stars 5.48k forks source link

fix: use window.location.href instead of history.push for /login page #20878

Open narcistesa opened 1 day ago

narcistesa commented 1 day ago

Fixes #20874

The ArgoCD UI replaces the browser history to navigate to /login?return_url=... without reloading the page. This behaviour is causing issues for anybody who wants to catch or rewrite the /login location in their ingress controller.

Checklist:

bunnyshell[bot] commented 1 day ago

:white_check_mark: Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-fpebug.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-fpebug.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):